Fix: Runloop might be suspended when assigned with many partitions #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Runloop command queue is a bounded queue, with a fixed size of 1024 - The Runloop stream takes commands from the queue, process them and offer a new `Poll` command into the stream (when applicable). - The `.offer` can suspend the fiber when the command queue is already full. this, in turn, makes the entire stream freeze. the underlying kafka consumer will eventually (after `max.poll.interval.ms`) be dropped from the group without any notification to the zstream. - to fix this, we can change the command queue from bounded to unbounded which will not suspend the fiber that adds the `Poll` command
|
|
|
👍 As expressed on Discord, unbounded memory usage is something to be avoided in general, but in this case it's preferrable over freezing. Should this lead to trouble, it's at least easily diagnosed as OOM errors. |
svroonland
approved these changes
Jul 19, 2023
|
@svroonland any idea why the benchmark fails? it fails on lack of permissions |
guizmaii
approved these changes
Jul 19, 2023
erikvanoosten
approved these changes
Jul 19, 2023
|
@yaarix benchmarks don't work on forks |
Closed
|
@yaarix It's been a long time since this issue, but have you actually experienced this issue or was it just a theoretical one? |
|
I have experienced it and merged a fix a long time ago |
|
Thanks for the quick response. Alright, then we'll cancel plans for #1386 (completely forgot about this issue here) unless we have a good idea what exactly caused it and how we can mitigate that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pollcommand into the stream (when applicable)..offercan suspend the fiber when the command queue is already full. this, in turn, makes the entire stream freeze. the underlying kafka consumer will eventually (aftermax.poll.interval.ms) be dropped from the group without any notification to the zstream.Pollcommand