[WIP] Fix commit mechanism design #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
force-pushed
the
fix_commit_interface
branch
2 times, most recently
from
a54b718 to
596096f
Compare
guizmaii
force-pushed
the
fix_856
branch
2 times, most recently
from
074bddf to
38a4ac1
Compare
guizmaii
force-pushed
the
fix_commit_interface
branch
3 times, most recently
from
62efd7c to
99ff1d3
Compare
guizmaii
force-pushed
the
fix_commit_interface
branch
from
99ff1d3 to
8c0614f
Compare
guizmaii
force-pushed
the
fix_commit_interface
branch
from
8c0614f to
13f41e6
Compare
guizmaii
force-pushed
the
fix_commit_interface
branch
from
13f41e6 to
363140f
Compare
|
|
guizmaii
force-pushed
the
fix_commit_interface
branch
from
79591d4 to
a6d8f27
Compare
guizmaii
force-pushed
the
fix_commit_interface
branch
from
382ea26 to
be8c78f
Compare
guizmaii
force-pushed
the
fix_commit_interface
branch
from
be8c78f to
8076be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, the fact that the
OffsetBatch(and theOffset) can commit themselves is a massive design mistake.It's very OO oriented and makes things more complicated than it should.
My goal is first to fix the design to be then able to fix #852