Run profiler only on release and on demand #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svroonland
reviewed
Nov 16, 2024
| @@ -24,6 +22,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| with: | |||
| ref: ${{ github.event.inputs.ref }} | |||
There was a problem hiding this comment.
Does it supply the right value for ref when running a release?
There was a problem hiding this comment.
The ref parameter has default value "" which means take the default branch. This is what we had before as well.
When this action is run from a release the ref input it not set. So I am actually not sure it this will work (does this evaluate to empty string when the ref is not set?). Perhaps we should give the input parameter an explicit default value of "".
There was a problem hiding this comment.
I added an explicit default value. So now it should be fine.
Since we are not using the cpu/heap profiles that much, it is an environmental offence to run the profiler on every commit. With this change we only run the profiler on releases. In addition, it is now easy to run the profiler on demand from any branch, tag or commit.
erikvanoosten
force-pushed
the
less-profiling
branch
from
454ded2 to
ba86c5e
Compare
svroonland
approved these changes
Nov 16, 2024
erikvanoosten
added a commit
that referenced
this pull request
Nov 16, 2024
When you start a workflow from the GitHub UI, it already asks for a branch/tag/commit. There is no need to add our own input for that. This is a follow-up of #1392.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are not using the cpu/heap profiles that much (if at all), IMHO it is an environmental offense to run the profiler on every commit.
With this change we only run the profiler on releases. In addition, it is now easy to run the profiler on demand from any branch, tag or commit.