Decouple stream halt detection timeout from max poll interval #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - restore some scaladoc - simpler way to get `maxPollInterval` - more warnings for providing java consumer
zio-kafka/src/main/scala/zio/kafka/consumer/internal/Runloop.scala
Outdated
Show resolved
Hide resolved
zio-kafka/src/main/scala/zio/kafka/consumer/internal/RunloopAccess.scala
Outdated
Show resolved
Hide resolved
svroonland
commented
Nov 12, 2024
zio-kafka/src/main/scala/zio/kafka/consumer/internal/RunloopAccess.scala
Outdated
Show resolved
Hide resolved
zio-kafka/src/main/scala/zio/kafka/consumer/internal/PartitionStreamControl.scala
Outdated
Show resolved
Hide resolved
zio-kafka/src/main/scala/zio/kafka/consumer/internal/PartitionStreamControl.scala
Outdated
Show resolved
Hide resolved
…StreamControl.scala Co-authored-by: Erik van Oosten <e.vanoosten@grons.nl>
erikvanoosten
approved these changes
Nov 13, 2024
svroonland
commented
Nov 13, 2024
| * Make sure that all records from a single poll (see [[withMaxPollRecords maxPollRecords]]) can be processed in this | ||
| * interval, even when there is no concurrency because the records are all in the same partition. | ||
| * | ||
| * The default is equal to [[withMaxPollInterval maxPollInterval]]). |
There was a problem hiding this comment.
Is this still correct, if so where is it set?
There was a problem hiding this comment.
In RunloopAccess:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1262