Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete RunloopTimeout and small improvements #1141

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

erikvanoosten
Copy link
Collaborator

  • Delete RunloopTimeout as it is no longer used.
  • Do not suppress error in commitTransactionWithOffsets (even though the only invoker still dies upon any error).
  • Better debug logging in Runloop.
  • Shave tens of seconds of test by never taking more messages than can be sent.
  • Run test less often, 3 times is enough (`nonFlaky(3)`` runs the test 4 times!).

* `RunloopTimeout` is no longer used.
* Do not suppress error in `commitTransactionWithOffsets`.
* Better debug logging in `Runloop`.
* Shave tens of seconds of test by never taking more messages than can be sent.
* Run test less often, 3 times is enough (`nonFlaky(3)`` runs the test 4 times!).
@erikvanoosten erikvanoosten marked this pull request as ready for review December 22, 2023 10:44
Copy link
Collaborator

@svroonland svroonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@erikvanoosten erikvanoosten merged commit d2aa7f7 into master Dec 22, 2023
13 checks passed
@erikvanoosten erikvanoosten deleted the small-improvements branch December 22, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants