Add separate char codec to handle control characters #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkharderdev
changed the title
|
@fsvehla Can you do a quick review? Would be good to get this in |
|
Looks good! Thanks, @thinkharderdev. Will cut a release including this later this week. |
brbrown25
pushed a commit
to brbrown25/zio-json
that referenced
this pull request
Mar 16, 2021
* Add minimal test case for tab encoding issue * Create separate char codec for handling control characters * Remove commented Co-authored-by: thinkharder <thinkharderdev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current encoding/decoding is broken for control characters (\t, \n, etc). Need to handle those characters differently for string and single char encoding to be able to successfully decode.