Add JsonCodec derivation from encoder and decoder #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guersam
commented
May 14, 2024
| @@ -190,4 +188,6 @@ private[json] trait CodecLowPriority3 { this: JsonCodec.type => | |||
| implicit val uuid: JsonCodec[java.util.UUID] = JsonCodec(JsonEncoder.uuid, JsonDecoder.uuid) | |||
|
|
|||
| implicit val currency: JsonCodec[java.util.Currency] = JsonCodec(JsonEncoder.currency, JsonDecoder.currency) | |||
|
|
|||
| implicit def fromEncoderDecoder[A](implicit encoder: JsonEncoder[A], decoder: JsonDecoder[A]): JsonCodec[A] = new JsonCodec(encoder, decoder) | |||
There was a problem hiding this comment.
Changed the name from apply because it conflicts with the autogenerated apply function for case class JsonCodec.
guersam
force-pushed
the
codec-from-encoder-decoder
branch
from
e986ee6 to
ef21ec3
Compare
|
There's a problem with Scala 2.12 🤔 Is it acceptable to provide the derivation for 2.13 or above only? |
jdegoes
approved these changes
May 15, 2024
|
@guersam Yes, that's acceptable. |
ThijsBroersen
pushed a commit
to ThijsBroersen/zio-json
that referenced
this pull request
Jun 13, 2024
* Add JsonCodec derivation from encoder and decoder * Disable JsonCodec derivaton from encoder & decoder for Scala 2.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
summon[JsonCodec[zio.json.ast.Json]]fails even though there are implicit encoder and decoder.This PR allows codec derivation for types that already have encoder and decoder, in the same way of the current collection codec derivation.