-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add documentation on AST and Cursor #1098
docs: Add documentation on AST and Cursor #1098
Conversation
docs/decoding.md
Outdated
|
||
To get the AST representation of a JSON string, use the `fromJson[Json]` method. | ||
|
||
```scala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer using compile-safe code snippets to keep the documents up-to-date using mdoc
modifiers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right... it even says so in the docs contribution guidelines. Sorry, missed that - will update my PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Note that the CI now fails because of an non-up-tp-date README file, which seems to relate to 61b7634
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the CI now fails because of an non-up-tp-date README file, which seems to relate to 61b7634
@BalduinLandolt
Please update the PR from upstream series/2.x
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khajavi thanks for updating it! Should be good to merge now?
165c818
to
764325a
Compare
@khajavi ping 🙂 |
Co-authored-by: Milad Khajavi <khajavi@gmail.com>
I really like the latest additions to the decoding documentation.
However, I feel that the concepts of the AST and Cursor aren't really introduced/explained to the extent that the examples would make sense for someone who isn't already familiar with the concepts.
I jotted down a little something. But I'm also happy to make changes or see this changed by the maintainers.
Also, since the
decoding.md
page is getting pretty long, it might be worth changing some of the overall structure of the documentation, maybe with an additional level of page nesting.That's of course not mine to decide, but I'd be happy to contribute to it, if I can.