Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modvar and create new pager #4194

Merged
merged 7 commits into from
Mar 31, 2020
Merged

Add modvar and create new pager #4194

merged 7 commits into from
Mar 31, 2020

Conversation

craigh
Copy link
Member

@craigh craigh commented Mar 31, 2020 •
edited
Loading

add modvar for items per page to ZAuth mappings list

also remove legacy pager and user doctrine pager with custom wrapper

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets -
Refs tickets refs #2915
License MIT
Changelog updated yes

@craigh
add modvar for items per page to ZAuth mappings list
b513d71 
refs #2915

also remove legacy pager and user doctrine pager with custom wrapper
@craigh craigh added this to the 3.0.0 milestone Mar 31, 2020
@craigh craigh self-assigned this Mar 31, 2020
@Guite
Copy link
Member

Guite commented Mar 31, 2020

Did you also look at https://github.com/KnpLabs/KnpPaginatorBundle ?

@craigh craigh changed the title [WIP] add modvar and create new pager Add modvar and create new pager Mar 31, 2020
@craigh craigh requested a review from Guite March 31, 2020 11:57
@Guite
Copy link
Member

Guite commented Mar 31, 2020

Did you also look at https://github.com/KnpLabs/KnpPaginatorBundle ?

Does your "thumbs down" mean that you didn't look or that you don't like it?

@Guite
Copy link
Member

Guite commented Mar 31, 2020

How about deprecating the old pagers?

@craigh
Copy link
Member Author

craigh commented Mar 31, 2020

I didn't look at it until your link. I don't like it because Doctrine already provides most of the solution. This solution is simple and doesn't require a full-blown bundle.

@craigh craigh merged commit ca49fac into master Mar 31, 2020
@craigh craigh deleted the pagers branch March 31, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guite Guite Guite approved these changes

Assignees

@craigh craigh

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@craigh @Guite