Routing enhancements #1676
Routing enhancements #1676
Conversation
|
will this require changes to modules utilizing the previous version of routing - like ExtensionLibrary for example? |
|
No, only the 'el' prefix should be removed, as this is added automatically now. |
|
do the docs require adjustment? |
|
should the routes module be moved to /system then? |
In the end, yes, but I had it in modules for now to be able to install / uninstall it. |
|
i say throw caution to the wind and put it in. 😀 |
|
I just wanna mention that I won't be able to answer for the next few days |
|
good luck! |
|
Under a clean install of Zikula, the Routes module needs to be installed before you restore the contents of the "routing.yml" file. Otherwise, you will experience the following error: FileLoaderLoadException: Cannot import resource "." from "/app/config/routing.yml". (An exception occurred while executing 'SELECT t0.id AS id1, t0.workflowState AS workflowState2, t0.route_path AS route_path3, t0.host AS host4, t0.schemes AS schemes5, t0.methods AS methods6, t0.route_defaults AS route_defaults7, t0.requirements AS requirements8, t0.options AS options9, t0.route_condition AS route_condition10, t0.description AS description11, t0.bundle AS bundle12, t0.userRoute AS userRoute13, t0.sort AS sort14, t0.createdUserId AS createdUserId15, t0.updatedUserId AS updatedUserId16, t0.createdDate AS createdDate17, t0.updatedDate AS updatedDate18 FROM zikula_routes_route t0 WHERE t0.workflowState = ? ORDER BY t0.sort ASC' with params ["approved"]: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'example.zikula_routes_route' doesn't exist) |
|
I will work on this in a few days when I have more time. |
|
this may need to be rebased. |
|
This is ready to be merged. Important: Right after this one is merged, #1721 needs to be merged, as the core won't work otherwise. I decided to split the PRs to make it possible to distinguish between Core changes and the new module. |
|
Give me a day to review the code. Looks interesting :) |
|
are these fixes no longer required?
|
Without these, the sorting of the routes will not work properly, however this is not that important and can be fixed later on. |
|
looks like Travis doesn't like your version of Composer... |
|
fix for #1704 pending 😄 |
| ``` | ||
| 2. `ModUtil::url()` will try to generate a new-styled Symfony url if possible. However, This function is deprecated, | ||
| for url generation in PHP and Twig take a look at [the Symfony docs](http://symfony.com/doc/current/book/routing.html#generating-urls). | ||
| There is no way to generate new-styled urls in Smarty other than using the deprecated `{modurl}`. |
There was a problem hiding this comment.
what about writing a new smarty plugin?
There was a problem hiding this comment.
Could be done, but not as part of this PR - added to the Routing task list at #1552.
It's because the RoutingModule part of this PR is moved into the other PR. |
|
Can you rebase this, I'm ready to merge it, |
… as long as no generated configuration is available. Also added a method to get configuration formatted for html.
|
Rebased now. |
ghost
merged commit [TO BE MERGED RIGHT AFTER #1676] Added the ZikulaRoutesmodule
Swiftmailer improvements refs #1676
This PR removes the previously added
CmfRoutingBundle(which is not needed anymore) and adds theI18nRoutingBundlefor multilingual routing. See the PR's files for further written documentation.Additionally I wrote a MOST-based ZikulaRoutesModule beeing a new system module managing routing, which is added in #1721.
Instructions:
Todo