Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to delete stale pending registrations #4069

Closed
paustian opened this issue Jan 17, 2020 · 10 comments · Fixed by #4192
Closed

Add the ability to delete stale pending registrations #4069

paustian opened this issue Jan 17, 2020 · 10 comments · Fixed by #4192
Assignees
Labels
Milestone

Comments

@paustian
Copy link
Member

paustian commented Jan 17, 2020

This should also be something the Core does automatically if the time to register expires.

Q A
Zikula Version 2.0.15
PHP Version all

Summary

Deleting all users should be a simple sql call to the database and implemented in UserRegistry. Since they are pending users, they should have no attachment to any other modules so removing them should not cause any consequences.

Desired Behavior

Have a button in the interface for users would be the simplest implementation. Pressing it gets rid of the users.

Possible Solution

After pressing it, an Are you Sure dialog would be nice. If yes, all stale pending users are deleted.

Context

My sites accumulate a ton of pending users. It woudl be nice to get rid of them.

@Guite Guite added this to the 3.0.0 milestone Jan 17, 2020
@craigh craigh changed the title Add the ability to delete stale pending registrations. This should also be something the Core does automatically if the time to register expires Add the ability to delete stale pending registrations Jan 20, 2020
@Kaik
Copy link
Contributor

Kaik commented Feb 1, 2020

I think this feature should come with additional options like search and pagination.

  1. there might be huge amount of "pendings" and simple delete all will end up with 500...
  2. search because sometimes you do want to filter by domain or date etc..
  3. some modules can work on pending registrations so delete event will probably be fired anyway...

btw @paustian I guess your pendings are spam you can try to reduce them via banned email domains feature in settings module...

@Guite
Copy link
Member

Guite commented Feb 1, 2020

via banned email domains feature in settings module...

-> Users module

@Kaik
Copy link
Contributor

Kaik commented Feb 1, 2020

yes sorry

@Kaik
Copy link
Contributor

Kaik commented Feb 1, 2020

since pending is "just" a status and 3party modules are handled by events anyway it may also be just an upgrade - improvements in users list #3953

Main problem is that there is no proper way to target a specific group of users(including or not pendings) and then perform delete action on them.

@Guite Guite modified the milestones: 3.0.0, 3.1.0 Feb 7, 2020
@craigh craigh self-assigned this Feb 7, 2020
@craigh
Copy link
Member

craigh commented Feb 7, 2020

I'll take this one (eventually but for 3.0)

@Kaik
Copy link
Contributor

Kaik commented Feb 8, 2020

take a look on #3953 too and please consider databases like 40k+ users

@craigh
Copy link
Member

craigh commented Mar 10, 2020

@paustian. When we initially talked about this, I thought you were talking about automatic removal based on an expiry date. Your ticket indicates a more manual approach. which do you prefer?

@craigh
Copy link
Member

craigh commented Mar 20, 2020

ping @paustian

@paustian
Copy link
Member Author

Craig, automatic woudl be best, but I would be happy with either. Sorry for the slow response, I am frantically getting my classes on for next week.

@craigh
Copy link
Member

craigh commented Mar 23, 2020

refs #3928

craigh added a commit that referenced this issue Mar 25, 2020
craigh added a commit that referenced this issue Mar 29, 2020
Add email notification when registration is deleted refs #2915.
@craigh craigh mentioned this issue Apr 10, 2020
craigh added a commit that referenced this issue Apr 10, 2020
fix orphaned users on attempt to delete stale pending registrations.
closes #4218
refs #4069 #4192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants