Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix identifierLocFromIndex on escaped identifier #2039

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Techatrix
Copy link
Member

fixes #2023

@Sekky61
Copy link
Contributor

Sekky61 commented Sep 24, 2024

Works well for me. It also closes #2035.
I just found a small annoyance, see this test:

    try testHover(
        \\const @<cursor>"hello  world" = 42;
    ,
        \\```zig
        \\const @"hello  world" = 42
        \\```
        \\```zig
        \\(comptime_int)
        \\```
    );

It does not work on the left quote, but it does again work at the @.

@Techatrix
Copy link
Member Author

I just found a small annoyance, see this test:

This is caused in a different part of the codebase (position_context). Coincidentally I have worked on a refactor of that component which appears to fix this case. I will publish that in a separate PR.

@Techatrix Techatrix merged commit db05a1c into master Sep 26, 2024
4 checks passed
@Techatrix Techatrix deleted the techatrix/escaped-identifier-lookup branch November 8, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No inlay hints/hover/completions for @"i d e n t" syntax
2 participants