Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for _TZE204_dapwryy7 #3648

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bangert
Copy link
Contributor

@bangert bangert commented Dec 28, 2024

Proposed change

Add _TZE204_dapwryy7 to the list of known devices. For #3626

Additional information

I dont have the device myself. this is purely based on the information available in the linked issue.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (ec79b74) to head (67fbd78).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3648   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         322      322           
  Lines       10371    10371           
=======================================
  Hits         9318     9318           
  Misses       1053     1053           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prairiesnpr
Copy link
Contributor

For reference the z2m converter is here https://github.com/Koenkk/zigbee-herdsman-converters/blob/9ede78a950d703dac4e60271e08dabf7808661e6/src/devices/tuya.ts#L10736

I think this will require a separate quirk, the DPs don't seem to match the existing one.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Dec 29, 2024
@bangert
Copy link
Contributor Author

bangert commented Dec 30, 2024

Thanks for the feedback - true i didnt check that.

i would not hold this back, though, as it is a step in the right direction. with this change one can make (limited) use of the device - which is more than one can now. but thats not my call, obviously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants