quirk for ts0603 garage door module #3607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3607 +/- ##
==========================================
+ Coverage 89.85% 89.86% +0.01%
==========================================
Files 321 322 +1
Lines 10366 10379 +13
==========================================
+ Hits 9314 9327 +13
Misses 1052 1052 ☔ View full report in Codecov by Sentry. |
prairiesnpr
reviewed
Dec 13, 2024
zhaquirks/tuya/ts0603_garage.py
Outdated
|
|
||
| ( | ||
| TuyaQuirkBuilder("_TZE608_fmemczv1", "TS0603") | ||
| .tuya_onoff(dp_id=1) |
There was a problem hiding this comment.
Would a button be more appropriate here?
There was a problem hiding this comment.
Probably 😄 This is my first quirk so it wasn't easy. I've searched the repo and there aren't many examples of exposing entity as button in Homeassistant. Finally I "invented" something working and hopefully it is acceptable 😄
TheJulianJES
added
Tuya
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Added quirk for TS0603 _TZE608_fmemczv1
Additional information
Partially fixes #3263
Issue mentions both TS0603 by _TZE608_c75zqghm and TS0603 _TZE608_fmemczv1 but I don't have former one to verify if my quirk would work for it
Checklist
pre-commitchecks pass / the code has been formatted using Black