Move crypto.randomBytes() to crypto.random.bytes() #6821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedisct1
force-pushed
the
random.bytes
branch
2 times, most recently
from
2e6f34a to
5020e6a
Compare
daurnimator
added
the
standard library
|
IMO we should remove this public function from the |
|
Having it |
jedisct1
force-pushed
the
random.bytes
branch
from
5020e6a to
bd3ad0c
Compare
andrewrk
reviewed
Oct 29, 2020
Comment on lines
+123
to
+125
| pub const random = struct { | ||
| pub const bytes = std.os.getrandom; | ||
| }; |
There was a problem hiding this comment.
I think I didn't explain the idea well enough. It is to make std.crypto.random be an instance of the Random interface backed by a thread-local CSPRNG - #6704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes things a little bit more organized and was suggested by Andrew.