Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a run at #352.
There are a couple of outstanding questions here:
You can find an implementation of ASan's SanitizerCoverage runtime here: https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp. If Zig decides to act similarly to the SanitizerCoverage runtime here, we also need to support disk access in the compiler_rt.
Thoughts on 1)
The LLVM coverage report server (
tools/sancov/coverage-report-server.py
) generates highlighted HTML from SanitizerCoverage files, but I was imagining more what Go does, e.g.:Alternatively we could write out the coverage file:
And then provide a tool for collecting more information:
The advantage of writing out a coverage file is other members of the Zig community could create external software that takes advantage of Zig coverage files and e.g. produce more graphical representations like stylized HTML output.