Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/compiler/build_runner: only build Fuzz on 64-bit platforms #23018

Merged

Conversation

bradobro
Copy link
Contributor

@andrewrk here is a cleaner PR.

Addresses #22523 by dead-coding Fuzz.Start() on non-64-bit platforms.

Replaces: PR 23008
Reason: omitting the unnecessary changes I'd proposed to Fuzz/WebServer.zig.

@bradobro bradobro changed the title compiler.build_runner: only build Fuzz on 64-bit platforms lib/compiler/build_runner: only build Fuzz on 64-bit platforms Feb 26, 2025
@andrewrk
Copy link
Member

andrewrk commented Feb 26, 2025

Thanks. You can just leave this as-is and I'll take it from here.

btw idk if you are interested in unsolicited git tips but if you plan on doing more open source collaboration, it might be worth learning how to do a git rebase workflow to update an existing PR. maybe start here

@andrewrk andrewrk merged commit c031b62 into ziglang:master Feb 27, 2025
9 checks passed
@andrewrk
Copy link
Member

Thanks!

@bradobro
Copy link
Contributor Author

Thanks Andrew. I'll look at the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants