Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Darwin declarations #21929

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

danielchasehooper
Copy link
Contributor

These types are necessary to use functions that are already pulled into c.zig from std/c/darwin.zig, like the mach_vm_*() functions.

I almost certainly didn't get all the missing pub declarations, these are just the ones I've needed for what I'm working on. Is there a better way to do this? Should c.zig's const darwin be pub? Should platform specific stuff get moved up a level to std.darwin/std.freebsd/etc files?

@andrewrk
Copy link
Member

andrewrk commented Nov 6, 2024

Thanks!

@andrewrk andrewrk enabled auto-merge (squash) November 6, 2024 19:57
@andrewrk
Copy link
Member

andrewrk commented Nov 6, 2024

Is there a better way to do this? Should c.zig's const darwin be pub? Should platform specific stuff get moved up a level to std.darwin/std.freebsd/etc files?

That's a question I am intentionally deferring until the language is done. Probably there will be some boring answer such as, "we will delete all the libc declarations not used by the standard library before releasing 1.0".

@andrewrk andrewrk merged commit ee9f00d into ziglang:master Nov 7, 2024
10 checks passed
@danielchasehooper danielchasehooper deleted the missing_darwin branch November 7, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants