Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value: implement isUndefDeep #21412

Closed
wants to merge 1 commit into from

Conversation

wrongnull
Copy link
Contributor

I noticed a TODO in the comments for this function and decided to implement it.

@wrongnull wrongnull marked this pull request as draft September 15, 2024 11:44
@mlugg
Copy link
Member

mlugg commented Sep 16, 2024

As mentioned by Jacob on Zulip, this is the wrong approach to take here; instead, InternPool.get should canonicalize aggregates with all-undef fields. This isn't your fault, the TODO comment is just wrong.

@mlugg mlugg closed this Sep 16, 2024
@wrongnull
Copy link
Contributor Author

wrongnull commented Sep 16, 2024

As mentioned by Jacob on Zulip, this is the wrong approach to take here; instead, InternPool.get should canonicalize aggregates with all-undef fields. This isn't your fault, the TODO comment is just wrong.

Ok, maybe I'll reopen this pr with desired changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants