Faster Ast.zig #21381
Closed
Faster Ast.zig #21381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
reviewed
Sep 11, 2024
lib/std/zig/Ast.zig
Outdated
| const estimated_token_count = @max(64, bytes_left / 8); | ||
| const estimated_total = tokens.len + estimated_token_count; | ||
| try tokens.ensureTotalCapacity(gpa, estimated_total); | ||
| for (0..estimated_token_count) |_| { |
RetroDev256
force-pushed
the
faster-ast
branch
4 times, most recently
from
4dd48f8
to
a65e0e7
Compare
RetroDev256
force-pushed
the
faster-ast
branch
from
a65e0e7
to
e50f4cb
Compare
squeek502
reviewed
Sep 11, 2024
ArrayList/MultiArrayList .shrinkAndFree can swallow an OOM, but this is correct.
RetroDev256
force-pushed
the
faster-ast
branch
from
5b8a72f
to
2c88736
Compare
Rexicon226
suggested changes
Sep 11, 2024
|
This PR could be improved. I found a few more optimizations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to eek a little more speed out of ast-check:
("old-zig" in this is master as of b817823, "new-zig" is this PR)
While I haven't tested it, this should also reduce a little memory usage after generating the AST.