Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: add arch bits for s390x-linux #21342

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Sep 8, 2024

[meghan@nixos:~/dev/zigmod]$ ~/src/zig/build/stage3/bin/zig build -Dtarget=s390x-linux-musl

[nix-shell:~/dev/zigmod]$ qemu-s390x ./zig-out/bin/zigmod 
zigmod dev linux s390x musl

The commands available are:
  - version
  - fetch
  - ci
  - init
  - sum
  - zpm
  - license
  - aq
  - generate
[nix-shell:~/src/zig]$ ./build/stage3/bin/zig test test/behavior.zig -target s390x-linux-musl --test-cmd qemu-s390x --test-cmd-bin
<snip>
1837 passed; 122 skipped; 0 failed.
[nix-shell:~/src/zig]$ ./build/stage3/bin/zig test lib/std/std.zig --zig-lib-dir lib -target s390x-linux-musl --test-cmd qemu-s390x --test-cmd-bin
unexpected errno: 14
[default] (warn): unable to spawn thread for printing progress to terminal: Unexpected
unexpected errno: 14
43/2794 array_hash_map.test.basic hash map usage...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
44/2794 array_hash_map.test.iterator hash map...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
45/2794 array_hash_map.test.ensure capacity...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
46/2794 array_hash_map.test.ensure capacity leak...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
47/2794 array_hash_map.test.big map...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
48/2794 array_hash_map.test.clone...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
49/2794 array_hash_map.test.shrink...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
50/2794 array_hash_map.test.pop...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
51/2794 array_hash_map.test.popOrNull...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
52/2794 array_hash_map.test.reIndex...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
54/2794 array_hash_map.test.sort...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
55/2794 array_hash_map.test.0 sized key...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
58/2794 array_list.test.initCapacity...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
59/2794 array_list.test.clone...FAIL (OutOfMemory)
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
unexpected errno: 14
thread 17635 panic: attempt to unwrap error: OutOfMemory
unexpected errno: 14
Unable to dump stack trace: OutOfMemory
error: the following test command crashed:
qemu-s390x /home/meghan/zig-cache/o/97dd54a8b686bfb89b4d6ed4b00cef55/test

test/behavior/union.zig Outdated Show resolved Hide resolved
lib/std/os/linux/s390x.zig Outdated Show resolved Hide resolved
lib/std/os/linux/s390x.zig Outdated Show resolved Hide resolved
test/behavior/var_args.zig Outdated Show resolved Hide resolved
PATH: bool = false,
_: u10 = 0,

// #define O_RSYNC 04010000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hadnt decided if/how to expose them, they have multiple bits set

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember running into a similar conundrum with some termios stuff in std.os.linux a few weeks ago... I'm not sure if there is a good answer to this with packed structs.

@alexrp
Copy link
Member

alexrp commented Sep 13, 2024

Looks like this needs a rebase.

@nektro nektro mentioned this pull request Sep 13, 2024
8 tasks
@andrewrk andrewrk merged commit 5e4da1f into ziglang:master Sep 24, 2024
10 checks passed
@nektro nektro deleted the nektro-patch-36672 branch September 24, 2024 20:41
DivergentClouds pushed a commit to DivergentClouds/zig that referenced this pull request Sep 24, 2024
richerfu pushed a commit to richerfu/zig that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants