Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated default initializations with decl literals #21287

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

linusg
Copy link
Contributor

@linusg linusg commented Sep 2, 2024

Follow-up to 0b9fccf.

@linusg
Copy link
Contributor Author

linusg commented Sep 2, 2024

ah, I suppose this needs a zig1.wasm update to work...

@mlugg
Copy link
Member

mlugg commented Sep 2, 2024

Yep, that's why I held off on doing it in that PR. However, this work is still valuable, so keep it around! Once we've done a zig1.wasm update we can merge this.

By the way, I haven't looked over all of the changes here, but InternPool shouldn't use default values at all -- instead, it should probably expose a pub const empty: InternPool = .... That's because many of the field values are tied together.

@linusg linusg marked this pull request as draft September 2, 2024 23:29
@mlugg
Copy link
Member

mlugg commented Sep 11, 2024

@linusg #21367 contained a zig1.wasm update, so you should be good to go ahead with this branch now if you rebase!

@linusg
Copy link
Contributor Author

linusg commented Sep 11, 2024

Rebased, did a quick sweep of newly added = .{}, added InternPool.empty in a separate commit.

@linusg linusg marked this pull request as ready for review September 11, 2024 21:54
@mlugg mlugg merged commit 0001f91 into ziglang:master Sep 12, 2024
10 checks passed
@linusg linusg deleted the deprecated-default-init branch September 12, 2024 18:56
DivergentClouds pushed a commit to DivergentClouds/zig that referenced this pull request Sep 24, 2024
Replace deprecated default initializations with decl literals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants