std.fs: Disable file operations on directories test on WASI with wasi-libc.
#21176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
reviewed
Aug 23, 2024
alexrp
force-pushed
the
wasi-disable-test
branch
from
10fb846
to
804780a
Compare
alexrp
changed the title
file operations on directories test on WASI.file operations on directories test on WASI with wasi-libc.
|
If this is merged, I suppose the CI machines could also be updated to a current Wasmtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20747
Wasmtime developers have acknowledged that this is a regression on their end. I propose that we disable this test temporarily so that new contributors using a recent Wasmtime version don't hit this and get confused (e.g. #20511 (comment)).