Add support for local copy of dependency trees #20150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is still in progress, currently by providing the argument
`--cache-dependencies-locally`, you can have grabbed dependencies stored
in a local `zig-deps` folder which theoretically should be viable for
checking in to your VCS.
However - there are a few unsolved problems:
- dependenices which are no longer depended on should probably be
removed.
- dependencies being stored flatly in the zig-deps folder by hash
makes it non-obvious which dependency is which (from a user POV).
Additionally, if you updated dependencies the hash (and by extension
folder name) will change - this then makes tracking logical changes
to dependencies in your version control system trickier.
I'm not entirely sure how to best solve these problems - one could be to
have some kind of naming-resolution scheme, alongside a local lock file
mapping names to hashes? This could be combined with a build option to
force hashes to be recomputed to validate the contents of these folders
have not changed (but having it as an option as it would be slower).
moosichu
force-pushed
the
feature/local-dependencies-cache
branch
from
01de893 to
7f38429
Compare
|
Checklist of things to do:
|
|
OK - I'm fairly keen to iterate on this one, as it's already proving super useful for when I'm relying on dependencies that no longer build with newer versions of zig. So having a path to edit them and check those fixes in directly (whilst still enabling the ability to update the dependencies with |
|
Linking some other discussions and problems that are relevant: |
|
The proposal this implements was rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is still in progress, currently by providing the argument
--cache-dependencies-locally, you can have grabbed dependencies stored in a localzig-depsfolder which theoretically should be viable for checking in to your VCS.However - there are a few unsolved problems:
I'm not entirely sure how to best solve these problems - one could be to have some kind of naming-resolution scheme, alongside a local lock file mapping names to hashes? This could be combined with a build option to force hashes to be recomputed to validate the contents of these folders have not changed (but having it as an option as it would be slower).
This would resolve #14283.