Compiler: move checking function-scope-only builtins to AstGen

[wrongnull]

No description provided.

[Vexu]

This check should be in AstGen.

[wrongnull]

This check should be in AstGen.

should I move check of all the functions such as @src or @setAlignStack to AstGen? If so, should I change the wording of the error message? Most of other builtins there use {builtinName} outside function scope meanwile @src for instance uses "@src outside function"

[Vexu]

should I move check of all the functions such as @src or @setAlignStack to AstGen?

Yes please.

If so, should I change the wording of the error message?

That would be nice; and easier to implement since you can just switch on the builtin kind at the top of builtinCall.

[wrongnull]

should I move check of all the functions such as @src or @setAlignStack to AstGen?

Yes please.

If so, should I change the wording of the error message?

That would be nice; and easier to implement since you can just switch on the builtin kind at the top of builtinCall.

It looks like astgen.fn_block is not null at least for comptime and test blocks. It's not yet clear for me, how to detect being exactly in function scope.

[nektro]

test blocks are indeed functions and should allow the builtins. it being non-null in comptime blocks seems sus though

[Vexu]

It looks like astgen.fn_block is not null at least for comptime and test blocks. It's not yet clear for me, how to detect being exactly in function scope.

It is null for comptime blocks and correctly not null for tests:

comptime {
    try 1; //error: 'try' outside function scope
}

[wrongnull]

It looks like astgen.fn_block is not null at least for comptime and test blocks. It's not yet clear for me, how to detect being exactly in function scope.

It is null for comptime blocks and correctly not null for tests:

comptime {
    try 1; //error: 'try' outside function scope
}

not sure if latest commit contains complete list of such functions but I'm think it is

[wrongnull]

@Vexu forgot about @src sorry

[andrewrk]

Before, there was only one branch on the builtin tag. Now it does it twice. The way it was before was better, where it had if statements inside each of the branches of the switch.

If you wish to consolidate this information and make it declarative, then add a field to src/BuiltinFn.zig, don't add another switch like this.

@Vexu

[wrongnull]

Before, there was only one branch on the builtin tag. Now it does it twice. The way it was before was better, where it had if statements inside each of the branches of the switch.

If you wish to consolidate this information and make it declarative, then add a field to src/BuiltinFn.zig, don't add another switch like this.

@Vexu

I can rewrite it in next pr

[andrewrk]

Thanks