codegen/llvm: truncate padding bits when loading a non-byte-sized value #17391
+321
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generalisation of @jacobly0 #16605 to support optional and unions.
llvm appears to assume padding bits are "properly set" when using
llvm.load i4
:https://llvm.org/docs/LangRef.html#load-instruction
so llvm assumes the
and
is redundant and doesn't generate code to mask out the bits.after this commit, this byte code is generated instead, and the hi bits are properly zeroed:
closes #14200
also, a pair of bugs seem to be fixed now by this or previous commits -> add a test case.
closes #9674
closes #16581