introduce the zig fetch subcommand and symlink support in zig packages
#17363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ianprime0509 - would you be willing to add the git.zig logic to add symlink support here? |
|
Awesome! Sure, I'll take a closer look at this after work and send a patch to add support for this in Git. |
There are no functional changes in this commit.
zig fetch [options] <url> zig fetch [options] <path> Fetches a package which is found at <url> or <path> into the global cache directory, printing the package hash to stdout. Closes #16972 Related to #14280 Additionally, this commit: * Adds uncompressed .tar support to package fetching * Introduces symlink support to package fetching
* Package: use std.tar diagnostics to give detailed error messages * std.tar: add diagnostic for unsupported file type
eagerly awaiting @vesim987's upcoming PR for this |
|
Note that |
|
@andrewrk not sure what would be most convenient for you (maybe I should just send a follow-up PR once this is merged), but here's a patch to integrate this with This is able to fetch the dependency in this PR: kristoff-it/orca-ui-hello-zig#1 Sample when the underlying filesystem doesn't support symlinks: |
|
If you're fine with it, I can cherry-pick from your zig fork into this branch |
|
That sounds like an easier idea, I just pushed it up here: https://github.com/ianprime0509/zig/tree/tar-symlinks |
|
Commit looks great 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches a package which is found at
<url>or<path>into the global cache directory, printing the package hash to stdout.Closes #16972
Related to #14280
Additionally, this branch:
Merge Checklist
more kinds of symlink metadata in std.tareagerly awaiting @vesim987's upcoming PR for this