give BSDs some attention #13699

mikdusan · 2022-11-29T17:32:28Z

make general progress on tier-2 BSDs
there may be some minor patches for macOS and others included

please see status/details in #13700

semarie · 2022-12-03T13:40:26Z

FYI, openbsd build work well with the diff, and tests are still passing.

theoparis · 2022-12-27T23:06:02Z

Is it just me or does building this PR cause an entire 64 gb of swap to be used when compiling stage3 (build-host-zig) with zig-bootstrap 🤔

I tried to use zig bootstrap but I replaced the zig folder with your bsd branch and it seems to be causing this massive memory leak.

lib/std/os.zig

mikdusan · 2022-12-28T01:16:34Z

Is it just me or does building this PR cause an entire 64 gb of swap to be used when compiling stage3 (build-host-zig) with zig-bootstrap 🤔

It's not just you! Trying to narrow down what is causing this. Strange tho, I am able to manually use the ld.lld args with BOTH zig ld.lld and even my dep llvm toolchain's ld.lld and linking succeeds without eating up huge GB's.

update: I threw out the mission-creep of linking to system c++ via regular -l options and thus the massive memory grab doesn't manifest anymore

semarie · 2022-12-31T08:54:09Z

@mikdusan do you think that PR could be splitted and commits incrementally done (instead of pushing all in one big PR) ?

currently, several OS are broken waiting for only some commits in this PR (like "avoid Dir.realpathAlloc").

having a good BSD support is a very good target (and thanks for your work on it), but I would be glad to have a working compiler too.

mikdusan · 2022-12-31T14:34:17Z

@mikdusan do you think that PR could be splitted and commits incrementally done (instead of pushing all in one big PR) ?

I'd like to get a review from andrew first. But yeah if it makes some pieces land faster, I'm open to splitting things up.

andrewrk

Thank you for giving some attention to the BSDs. In particular you have made me realize that a problematic commit has been residing in master branch for quite some time, which I have reverted.

I left a few review comments, but with those resolved, this changeset looks ready to merge to me.

src/main.zig

CMakeLists.txt

lib/libcxx/include/__config

src/Compilation.zig

- first convert to lower-case then perform mappings - effect: freebsd, netbsd and openbsd convert arch `amd64` to `x86_64` - effect: convert `arm64` to `aarch64`

- per darwin-xnu source, fcntl F_GETPATH will return ENOSPC when path exceeds either user-supplied buffer or system MAXPATHLEN - macOS does not document this (and other) possible errno values

- add conditional compile error - add conditional skip test

- https://github.com/DragonFlyBSD/DPorts/tree/master/devel/libc++/files for hints as to which patches are needed

- freebsd, netbsd, openbsd, dragonfly

- add netbsd - add dragonfly - fixup freebsd

This allows for a more optimal std.crypto.tlcsprng codepath. Without it a an "incorrect alignment" panic is triggered from crypto.tlcsprng which aligns a threadlocal but it's actually not aligned, thus detected by the safety check. It appears that LLVM-IR does attribute the storage with alignment but it is ultimately not respected in the final binary for netbsd and dragonfly.

andrewrk · 2023-01-03T05:57:30Z

Great work, thank you very much!

give BSDs some attention

mikdusan added os-freebsd os-netbsd os-openbsd os-dragonfly labels Nov 29, 2022

mikdusan mentioned this pull request Nov 29, 2022

give BSDs some attention #13700

Closed

mikdusan force-pushed the bsd branch 2 times, most recently from 4ab7715 to 76edf77 Compare November 29, 2022 23:48

andrewrk self-requested a review November 30, 2022 00:51

mikdusan force-pushed the bsd branch from 76edf77 to 583376b Compare November 30, 2022 07:28

wooster0 mentioned this pull request Nov 30, 2022

std.fs.MAX_NAME_BYTES: fix accessing MAXNAMLEN #13684

Closed

mikdusan force-pushed the bsd branch 3 times, most recently from 6b84514 to 3f167f5 Compare December 8, 2022 12:45

squeek502 mentioned this pull request Dec 9, 2022

debug info: resolve relative paths to source files into absolute paths #13843

Merged

mikdusan mentioned this pull request Dec 15, 2022

FreeBSD build fails unless I overwrite target name and add -Duse-zig-libcxx=true #13949

Closed

mikdusan force-pushed the bsd branch from 3f167f5 to f349be9 Compare December 25, 2022 02:23

daurnimator reviewed Dec 27, 2022

View reviewed changes

lib/std/os.zig Outdated Show resolved Hide resolved

lib/std/os.zig Outdated Show resolved Hide resolved

mikdusan force-pushed the bsd branch 2 times, most recently from 17430f0 to 1277900 Compare December 30, 2022 21:44

mikdusan marked this pull request as ready for review December 30, 2022 21:44

mikdusan force-pushed the bsd branch from 1277900 to 271aad4 Compare December 31, 2022 13:56

andrewrk requested changes Jan 2, 2023

View reviewed changes

src/main.zig Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

lib/libcxx/include/__config Show resolved Hide resolved

src/Compilation.zig Outdated Show resolved Hide resolved

mikdusan added 3 commits January 2, 2023 19:18

link.Elf: resolve CsuObjects TODO

d78a261

cmake: ignore case for TARGET ARCH/OS mapping

0cb8ed6

- first convert to lower-case then perform mappings - effect: freebsd, netbsd and openbsd convert arch `amd64` to `x86_64` - effect: convert `arm64` to `aarch64`

std.fs: add NAME_MAX for openbsd and netbsd

e872c72

mikdusan added 12 commits January 2, 2023 19:18

macos: getFdPath: handle E.NOSPC

4cdbde5

- per darwin-xnu source, fcntl F_GETPATH will return ENOSPC when path exceeds either user-supplied buffer or system MAXPATHLEN - macOS does not document this (and other) possible errno values

freebsd: getFdPath: < 13.1 fallback impl

5376247

freebsd: getFdPath: handle NameTooLong

bd071c9

freebsd: memfd_create: < 13.0 version check

7f012ee

- add conditional compile error - add conditional skip test

dragonfly: getFdPath: F_GETPATH implementation

7da9348

dragonfly: port libc++

1a40338

- https://github.com/DragonFlyBSD/DPorts/tree/master/devel/libc++/files for hints as to which patches are needed

netbsd: getFdPath: F_GETPATH implementation

e752606

std.Target: bump semver max for BSDs

46c3b09

- freebsd, netbsd, openbsd, dragonfly

build stage3: add more BSD support

ef08894

- add netbsd - add dragonfly - fixup freebsd

freebsd: add std.c.arc4random_buf

571b817

dragonfly: pass test: lib/std/std.zig

7798af7

mikdusan force-pushed the bsd branch from 271aad4 to 7798af7 Compare January 3, 2023 00:19

andrewrk merged commit 8bd734d into ziglang:master Jan 3, 2023

mikdusan deleted the bsd branch January 5, 2023 22:33

andrewrk added a commit that referenced this pull request Jan 9, 2023

Merge pull request #13699 from mikdusan/bsd

be6a81d

give BSDs some attention

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

give BSDs some attention #13699

give BSDs some attention #13699

mikdusan commented Nov 29, 2022 •

edited

Loading

semarie commented Dec 3, 2022

theoparis commented Dec 27, 2022 •

edited

Loading

mikdusan commented Dec 28, 2022 •

edited

Loading

semarie commented Dec 31, 2022

mikdusan commented Dec 31, 2022

andrewrk left a comment

andrewrk commented Jan 3, 2023

give BSDs some attention #13699

give BSDs some attention #13699

Conversation

mikdusan commented Nov 29, 2022 • edited Loading

semarie commented Dec 3, 2022

theoparis commented Dec 27, 2022 • edited Loading

mikdusan commented Dec 28, 2022 • edited Loading

semarie commented Dec 31, 2022

mikdusan commented Dec 31, 2022

andrewrk left a comment

Choose a reason for hiding this comment

andrewrk commented Jan 3, 2023

mikdusan commented Nov 29, 2022 •

edited

Loading

theoparis commented Dec 27, 2022 •

edited

Loading

mikdusan commented Dec 28, 2022 •

edited

Loading