-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Aro as a C frontend #10795
Closed
add Aro as a C frontend #10795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems to solve in this branch before merging: * Liveness and AIR printing want a ZIR instance. This issue is addressed by #10784. * linker: updateFunc / updateDecl want a Module instance which currently represents only Zig code. These functions should be changed to accept a Compilation, not a Module. The relevant state that it needed to touch on Module should be moved to Compilation instead. * `Decl` needs to be shared by both the C frontend and the Zig frontend. It currently has Zig-only fields and the functions to create Decl objects don't really fit the API that the C frontend needs. * A lot of the incremental compilation infrastructure doesn't quite match up, for example Decl objects being owned by Namespaces which is a Zig concept. Maybe there could be 1 Namespace globally across all C files and 1 more Namespace per C file for functions and globals declared `static`. * There is common code to be extracted from Sema that is shared with Aro frontend. All the helper functions having to do with the air_instructions and air_extra arrays. There are many instances of calling `@panic("TODO")` that need to be cleaned up. There is a lot of compiler options that Zig is not communicating to Aro, for example we do not pass the -D switches that we pass to Clang yet. Need to audit `addCCArgs` and do the equivalent things for setting up the Aro Compilation. The Aro code is copied from https://github.com/Vexu/arocc, commit 7a0e54227e1ea2b2df8aa7bd2b7075f735109317. The only patches are to delete Codegen and replace it with our own, and to delete main.zig, and add Type and Value to lib.zig. I believe the current plan is for main Aro development to happen upstream on the arocc repository and periodically sync it downstream with the Zig repository. It's up to @Vexu whether to keep that process or change it in the future.
next problem is there needs to be a namespace because it's needed for getting the file, for debug info source location purposes.
Current status on hello world:
I'm starting to wonder... should we perhaps lower to ZIR instead of AIR? The integration would be a lot less messy, and it's much more obvious how to parallelize it. One .c file would produce exactly one corresponding ZIR file. 🤔 🤔 🤔 |
Keeping the branch alive but closing the PR as I don't intend to merge this any time soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems to solve in this branch before merging:
addressed by make AIR instruction for assembly not reference ZIR #10784.
currently represents only Zig code. These functions should be changed
to accept a Compilation, not a Module. The relevant state that it
needed to touch on Module should be moved to Compilation instead.
Decl
needs to be shared by both the C frontend and the Zigfrontend. It currently has Zig-only fields and the functions to
create Decl objects don't really fit the API that the C frontend
needs.
match up, for example Decl objects being owned by Namespaces which is
a Zig concept. Maybe there could be 1 Namespace globally across all C
files and 1 more Namespace per C file for functions and globals
declared
static
.Aro frontend. All the helper functions having to do with the
air_instructions and air_extra arrays.
There are many instances of calling
@panic("TODO")
that need to becleaned up.
There is a lot of compiler options that Zig is not communicating to Aro,
for example we do not pass the -D switches that we pass to Clang yet.
Need to audit
addCCArgs
and do the equivalent things for setting upthe Aro Compilation.
The Aro code is copied from https://github.com/Vexu/arocc, commit
7a0e54227e1ea2b2df8aa7bd2b7075f735109317. The only patches are to delete
Codegen and replace it with our own, and to delete main.zig, and add
Type and Value to lib.zig.
I believe the current plan is for main Aro development to happen
upstream on the arocc repository and periodically sync it downstream
with the Zig repository. It's up to @Vexu whether to keep that process
or change it in the future.