Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig fmt odd indentation for comments inside of ternary if #3978

Closed
daurnimator opened this issue Dec 24, 2019 · 0 comments
Closed

zig fmt odd indentation for comments inside of ternary if #3978

daurnimator opened this issue Dec 24, 2019 · 0 comments
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. frontend Tokenization, parsing, AstGen, Sema, and Liveness. standard library This issue involves writing Zig code for the standard library.
Milestone
0.7.0

Comments

@daurnimator
Copy link
Contributor

In https://github.com/ziglang/zig/pull/3977/files#diff-e1a2433247d4abb2881d23eb041ec60dR52 I noticed this diff:

 else if (builtin.os == .windows) 
-    // https://locklessinc.com/articles/keyed_events/
+// https://locklessinc.com/articles/keyed_events/

IMO this isn't correct.
@daurnimator daurnimator mentioned this issue Dec 24, 2019
Merged
3 tasks
@andrewrk andrewrk added contributor friendly This issue is limited in scope and/or knowledge of Zig internals. frontend Tokenization, parsing, AstGen, Sema, and Liveness. standard library This issue involves writing Zig code for the standard library. labels Dec 31, 2019
@andrewrk andrewrk added this to the 0.7.0 milestone Dec 31, 2019
@LakeByTheWoods LakeByTheWoods mentioned this issue Feb 29, 2020
Closed
@daurnimator daurnimator mentioned this issue Jul 3, 2020
Open
LakeByTheWoods added a commit to LakeByTheWoods/zig that referenced this issue Aug 30, 2020
@LakeByTheWoods
zig fmt: Fix ziglang#3978, Fix ziglang#2748
08d8ffe
LakeByTheWoods added a commit to LakeByTheWoods/zig that referenced this issue Aug 30, 2020
@LakeByTheWoods
zig fmt: Fix ziglang#3978, Fix ziglang#2748
d2c88cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. frontend Tokenization, parsing, AstGen, Sema, and Liveness. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@andrewrk @daurnimator