Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive cache hit on compiler_rt and libfuzzer when used via the build system #20782

Closed
andrewrk opened this issue Jul 25, 2024 · 0 comments · Fixed by #20783
Closed
Labels
bug Observed behavior contradicts documented or intended behavior frontend Tokenization, parsing, AstGen, Sema, and Liveness.
Milestone

Comments

@andrewrk
Copy link
Member

andrewrk commented Jul 25, 2024

Zig Version

0.14.0-dev.569+4de8bba64

Steps to Reproduce and Observed Behavior

Use zig init to create a new project.

Build with zig build.

Make an edit to lib/compiler_rt.zig of the zig installation being used.

Run zig build again in the new project directory.

Observe that compiler_rt is not rebuilt.

Expected Behavior

The edits to compiler_rt.zig should be picked up.

In this case, the problem is that in Whole Cache Mode (used by the build system), the sub-compilation's source files do not make it into the cache manifest for the user application, so it does not check freshness of sub-compilation source files.

When a Compilation using Whole Cache Mode is working on a sub-Compilation, it must also add the child's file system inputs to the parent's cache manifest.

@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior frontend Tokenization, parsing, AstGen, Sema, and Liveness. labels Jul 25, 2024
@andrewrk andrewrk added this to the 0.14.0 milestone Jul 25, 2024
SammyJames pushed a commit to SammyJames/zig that referenced this issue Aug 7, 2024
igor84 pushed a commit to igor84/zig that referenced this issue Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Observed behavior contradicts documented or intended behavior frontend Tokenization, parsing, AstGen, Sema, and Liveness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant