fix some typos in 0.6.0 release notes #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Apr 13, 2020
| @@ -2444,7 +2444,7 @@ <h1>0.6.0 Release Notes</h1> | |||
| _ = 0xff00_00ff; | |||
| _ = 0b10000000_10101010; | |||
| _ = 0b1000_0000_1010_1010; | |||
| _ = 0x123_190.109_038_018p102; | |||
| _ = 0x123_190.109_038_018_102; | |||
There was a problem hiding this comment.
I think it's legit. That literal came from ziglang/zig#504 and docgen release-notes actually runs that code and it passes. https://en.cppreference.com/w/cpp/language/floating_literal also shows the same syntax.
|
Thanks! Will upload in a few minutes |
andrewrk
pushed a commit
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to read through the whole thing. Please double check that I didn't break the intending meaning of anything. Some of these changes are more anal than others. Speaking of which, "merge_anal_dumps"... yeesh.
Also, I liked the Zen programming language link.