Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken inventory error handling #1761

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

EdGue42
Copy link
Contributor

@EdGue42 EdGue42 commented Feb 21, 2025

When inventory errors are encountered and logged to the user during "Export DPM configurtion", the field "inventory-error-details" is only be present if "inventory-error-code" is 5. This change adds a corresponding check to avoid failing with a corresponding TypeError.

@EdGue42 EdGue42 added this to the 1.20.0 milestone Feb 21, 2025
@EdGue42 EdGue42 self-assigned this Feb 21, 2025
@EdGue42 EdGue42 force-pushed the edwin/fix/inventory-error-details branch from 7e56fe2 to 09307ba Compare February 21, 2025 08:32
When inventory errors are encountered and logged to the user
during "Export DPM configurtion", the field "inventory-error-details"
is only be present if "inventory-error-code" is 5. This change
adds a corresponding check to avoid failing with a corresponding TypeError.

Signed-off-by: Edwin Guenthner <edwin.guenthner@de.ibm.com>
@EdGue42 EdGue42 force-pushed the edwin/fix/inventory-error-details branch from 09307ba to e1d5b34 Compare February 24, 2025 09:25
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 81.327% (-0.02%) from 81.349%
when pulling e1d5b34 on edwin/fix/inventory-error-details
into a0b9d81 on master.

@EdGue42 EdGue42 merged commit 8e1b778 into master Feb 24, 2025
15 checks passed
@EdGue42 EdGue42 deleted the edwin/fix/inventory-error-details branch February 24, 2025 10:34
andy-maier pushed a commit that referenced this pull request Mar 11, 2025
When inventory errors are encountered and logged to the user
during "Export DPM configuration", the field "inventory-error-details"
is only be present if "inventory-error-code" is 5. This change
adds a corresponding check to avoid failing with a corresponding TypeError.

Signed-off-by: Edwin Guenthner <edwin.guenthner@de.ibm.com>
andy-maier pushed a commit that referenced this pull request Mar 11, 2025
When inventory errors are encountered and logged to the user
during "Export DPM configuration", the field "inventory-error-details"
is only be present if "inventory-error-code" is 5. This change
adds a corresponding check to avoid failing with a corresponding TypeError.

Signed-off-by: Edwin Guenthner <edwin.guenthner@de.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Export DPM configuration" expects inventory-error-details to always be present
3 participants