Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building docs and update docstrings #363

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Fix building docs and update docstrings #363

merged 3 commits into from
Mar 14, 2022

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Mar 14, 2022

In some circumstances, adding TORCH_PATH to the LD_LIBRARY_PATH environment variable will reduce some errors of finding CUDA.

Also, we add PyYAML in the requirements.txt to resolve the error when building docs.

@zhiqwang zhiqwang added code quality Code format and unit tests documentation Improvements or additions to documentation labels Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #363 (84d47ad) into main (228b586) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          11       11           
  Lines         776      776           
=======================================
  Hits          765      765           
  Misses         11       11           
Flag Coverage Δ
unittests 98.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228b586...84d47ad. Read the comment docs.

@zhiqwang zhiqwang changed the title Add TORCH_PATH to LD_LIBRARY_PATH Fix building docs and update docstrings Mar 14, 2022
@zhiqwang zhiqwang merged commit 9a27b91 into main Mar 14, 2022
@zhiqwang zhiqwang deleted the libtorch-path branch March 14, 2022 07:46
@zhiqwang zhiqwang added dependencies Pull requests that update a dependency file bug / fix Something isn't working labels Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working code quality Code format and unit tests dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant