Feat: Set default color scheme for the color registries (#108)

* Set default color scheme for the color registries * fix: Add unit test
zhaoyongjie · Nov 17, 2021 · dca5467 · dca5467
1 parent aee0f40
commit dca5467
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 19 deletions.
diff --git a/...erset_ui/superset-ui/packages/superset-ui-color/src/CategoricalSchemeRegistrySingleton.ts b/...erset_ui/superset-ui/packages/superset-ui-color/src/CategoricalSchemeRegistrySingleton.ts
@@ -1,8 +1,15 @@
 import { makeSingleton } from '@superset-ui/core';
 import CategoricalScheme from './CategoricalScheme';
 import ColorSchemeRegistry from './ColorSchemeRegistry';
+import schemes from './colorSchemes/categorical/d3';
 
-class CategoricalSchemeRegistry extends ColorSchemeRegistry<CategoricalScheme> {}
+class CategoricalSchemeRegistry extends ColorSchemeRegistry<CategoricalScheme> {
+  constructor() {
+    super();
+
+    this.registerValue('SUPERSET_DEFAULT', schemes[0]);
+  }
+}
 
 const getInstance = makeSingleton(CategoricalSchemeRegistry);
 

diff --git a/...perset_ui/superset-ui/packages/superset-ui-color/src/SequentialSchemeRegistrySingleton.ts b/...perset_ui/superset-ui/packages/superset-ui-color/src/SequentialSchemeRegistrySingleton.ts
@@ -1,8 +1,15 @@
 import { makeSingleton } from '@superset-ui/core';
 import ColorSchemeRegistry from './ColorSchemeRegistry';
 import SequentialScheme from './SequentialScheme';
+import schemes from './colorSchemes/sequential/d3';
 
-class SequentialSchemeRegistry extends ColorSchemeRegistry<SequentialScheme> {}
+class SequentialSchemeRegistry extends ColorSchemeRegistry<SequentialScheme> {
+  constructor() {
+    super();
+
+    this.registerValue('SUPERSET_DEFAULT', schemes[0]);
+  }
+}
 
 const getInstance = makeSingleton(SequentialSchemeRegistry);
 

diff --git a/...rary_superset_ui/superset-ui/packages/superset-ui-color/src/colorSchemes/sequential/d3.ts b/...rary_superset_ui/superset-ui/packages/superset-ui-color/src/colorSchemes/sequential/d3.ts
@@ -3,6 +3,23 @@
 import SequentialScheme from '../../SequentialScheme';
 
 const schemes = [
+  {
+    id: 'schemeRdBu',
+    label: 'red/blue',
+    isDiverging: true,
+    colors: [
+      '#67001f',
+      '#b2182b',
+      '#d6604d',
+      '#f4a582',
+      '#fddbc7',
+      '#d1e5f0',
+      '#92c5de',
+      '#4393c3',
+      '#2166ac',
+      '#053061',
+    ],
+  },
   {
     id: 'schemeBrBG',
     label: 'brown/green',
@@ -71,23 +88,6 @@ const schemes = [
       '#7f3b08',
     ],
   },
-  {
-    id: 'schemeRdBu',
-    label: 'red/blue',
-    isDiverging: true,
-    colors: [
-      '#67001f',
-      '#b2182b',
-      '#d6604d',
-      '#f4a582',
-      '#fddbc7',
-      '#d1e5f0',
-      '#92c5de',
-      '#4393c3',
-      '#2166ac',
-      '#053061',
-    ],
-  },
   {
     id: 'schemeRdGy',
     label: 'red/gray/black',

diff --git a/...ui/superset-ui/packages/superset-ui-color/test/CategoricalSchemeRegistrySingleton.test.ts b/...ui/superset-ui/packages/superset-ui-color/test/CategoricalSchemeRegistrySingleton.test.ts
@@ -0,0 +1,7 @@
+import { CategoricalScheme, getCategoricalSchemeRegistry } from '../src';
+
+describe('CategoricalSchemeRegistry', () => {
+  it('has default value out-of-the-box', () => {
+    expect(getCategoricalSchemeRegistry().get()).toBeInstanceOf(CategoricalScheme);
+  });
+});
diff --git a/..._ui/superset-ui/packages/superset-ui-color/test/SequentialSchemeRegistrySingleton.test.ts b/..._ui/superset-ui/packages/superset-ui-color/test/SequentialSchemeRegistrySingleton.test.ts
@@ -0,0 +1,7 @@
+import { SequentialScheme, getSequentialSchemeRegistry } from '../src';
+
+describe('SequentialSchemeRegistry', () => {
+  it('has default value out-of-the-box', () => {
+    expect(getSequentialSchemeRegistry().get()).toBeInstanceOf(SequentialScheme);
+  });
+});