Skip to content

Commit

Permalink
improvement: update error toast message
Browse files Browse the repository at this point in the history
  • Loading branch information
zhanglun committed Sep 14, 2023
1 parent 6fb8a67 commit 3dc8320
Show file tree
Hide file tree
Showing 8 changed files with 121 additions and 107 deletions.
8 changes: 7 additions & 1 deletion src-tauri/src/feed/channel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,13 @@ pub fn add_feed(feed: models::NewFeed, articles: Vec<models::NewArticle>) -> (us

let result = match result {
Ok(r) => (r, String::from("")),
Err(error) => (0, error.to_string()),
Err(error) => {
if let diesel::result::Error::DatabaseError(diesel::result::DatabaseErrorKind::UniqueViolation, _) = error {
return (0, "The feed you are trying to save already exists.".to_string())
} else {
return (0, error.to_string())
}
}
};

println!(" new result {:?}", result);
Expand Down
11 changes: 9 additions & 2 deletions src/components/AddFeed/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const AddFeedChannel = (props: any) => {
variant: "destructive",
title: "Unable to subscribe",
description: message,
duration: 2,
duration: 2000,
});

return;
Expand Down Expand Up @@ -85,10 +85,17 @@ export const AddFeedChannel = (props: any) => {
dataAgent
.addChannel(feedUrl)
.then((res) => {
console.log("%c Line:88 🥕 res", "color:#4fff4B", res);
if (res[1] === "") {
store.initCollectionMetas();
busChannel.emit("getChannels");
handleCancel();
} else {
toast({
variant: "destructive",
title: "Unable to subscribe",
description: res[1],
duration: 2000,
});
}
})
.finally(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/SettingPanel/Content/DialogDeleteFolder.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const DialogDeleteFolder = React.memo((props: DialogProps) => {
variant: "destructive",
title: "Ops! Something wrong~",
description: err.message,
duration: 2,
duration: 2000,
});
});
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SettingPanel/Content/DialogEditFeed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const DialogEditFeed = React.memo((props: DialogEditFeedProps) => {
variant: "destructive",
title: "Ops! Something wrong~",
description: err.message,
duration: 2,
duration: 2000,
});
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const DialogUnsubscribeFeed = React.memo((props: DialogProps) => {
variant: "destructive",
title: "Ops! Something wrong~",
description: err.message,
duration: 2,
duration: 2000,
});
});
}
Expand Down
12 changes: 5 additions & 7 deletions src/components/ui/Toaster.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
"use client";

import {
Toast,
ToastClose,
ToastDescription,
ToastProvider,
ToastTitle,
ToastViewport,
} from "@/components/ui/toast";
import { useToast } from "@/components/ui/use-toast";
} from "@/components/ui/toast"
import { useToast } from "@/components/ui/use-toast"

export function Toaster() {
const { toasts } = useToast();
const { toasts } = useToast()

return (
<ToastProvider>
Expand All @@ -27,9 +25,9 @@ export function Toaster() {
{action}
<ToastClose />
</Toast>
);
)
})}
<ToastViewport />
</ToastProvider>
);
)
}
62 changes: 31 additions & 31 deletions src/components/ui/toast.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import * as React from "react";
import * as ToastPrimitives from "@radix-ui/react-toast";
import { VariantProps, cva } from "class-variance-authority";
import { X } from "lucide-react";
import * as React from "react"
import * as ToastPrimitives from "@radix-ui/react-toast"
import { cva, type VariantProps } from "class-variance-authority"
import { X } from "lucide-react"

import { cn } from "@/helpers/cn";
import { cn } from "@/helpers/cn"

const ToastProvider = ToastPrimitives.Provider;
const ToastProvider = ToastPrimitives.Provider

const ToastViewport = React.forwardRef<
React.ElementRef<typeof ToastPrimitives.Viewport>,
Expand All @@ -15,28 +15,28 @@ const ToastViewport = React.forwardRef<
ref={ref}
className={cn(
"fixed top-0 z-[100] flex max-h-screen w-full flex-col-reverse p-4 sm:bottom-0 sm:right-0 sm:top-auto sm:flex-col md:max-w-[420px]",
className,
className
)}
{...props}
/>
));
ToastViewport.displayName = ToastPrimitives.Viewport.displayName;
))
ToastViewport.displayName = ToastPrimitives.Viewport.displayName

const toastVariants = cva(
"data-[swipe=move]:transition-none group relative pointer-events-auto flex w-full items-center justify-between space-x-4 overflow-hidden rounded-md border p-6 pr-8 shadow-lg transition-all data-[swipe=move]:translate-x-[var(--radix-toast-swipe-move-x)] data-[swipe=cancel]:translate-x-0 data-[swipe=end]:translate-x-[var(--radix-toast-swipe-end-x)] data-[state=open]:animate-in data-[state=closed]:animate-out data-[swipe=end]:animate-out data-[state=closed]:fade-out-80 data-[state=open]:slide-in-from-top-full data-[state=open]:sm:slide-in-from-bottom-full data-[state=closed]:slide-out-to-right-full",
"group pointer-events-auto relative flex w-full items-center justify-between space-x-4 overflow-hidden rounded-md border p-6 pr-8 shadow-lg transition-all data-[swipe=cancel]:translate-x-0 data-[swipe=end]:translate-x-[var(--radix-toast-swipe-end-x)] data-[swipe=move]:translate-x-[var(--radix-toast-swipe-move-x)] data-[swipe=move]:transition-none data-[state=open]:animate-in data-[state=closed]:animate-out data-[swipe=end]:animate-out data-[state=closed]:fade-out-80 data-[state=closed]:slide-out-to-right-full data-[state=open]:slide-in-from-top-full data-[state=open]:sm:slide-in-from-bottom-full",
{
variants: {
variant: {
default: "bg-background border",
default: "border bg-background text-foreground",
destructive:
"group destructive border-destructive bg-destructive text-destructive-foreground",
"destructive group border-destructive bg-destructive text-destructive-foreground",
},
},
defaultVariants: {
variant: "default",
},
},
);
}
)

const Toast = React.forwardRef<
React.ElementRef<typeof ToastPrimitives.Root>,
Expand All @@ -49,9 +49,9 @@ const Toast = React.forwardRef<
className={cn(toastVariants({ variant }), className)}
{...props}
/>
);
});
Toast.displayName = ToastPrimitives.Root.displayName;
)
})
Toast.displayName = ToastPrimitives.Root.displayName

const ToastAction = React.forwardRef<
React.ElementRef<typeof ToastPrimitives.Action>,
Expand All @@ -60,13 +60,13 @@ const ToastAction = React.forwardRef<
<ToastPrimitives.Action
ref={ref}
className={cn(
"inline-flex h-8 shrink-0 items-center justify-center rounded-md border bg-transparent px-3 text-sm font-medium ring-offset-background transition-colors hover:bg-secondary focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none disabled:opacity-50 group-[.destructive]:border-destructive/30 group-[.destructive]:hover:border-destructive/30 group-[.destructive]:hover:bg-destructive group-[.destructive]:hover:text-destructive-foreground group-[.destructive]:focus:ring-destructive",
className,
"inline-flex h-8 shrink-0 items-center justify-center rounded-md border bg-transparent px-3 text-sm font-medium ring-offset-background transition-colors hover:bg-secondary focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none disabled:opacity-50 group-[.destructive]:border-muted/40 group-[.destructive]:hover:border-destructive/30 group-[.destructive]:hover:bg-destructive group-[.destructive]:hover:text-destructive-foreground group-[.destructive]:focus:ring-destructive",
className
)}
{...props}
/>
));
ToastAction.displayName = ToastPrimitives.Action.displayName;
))
ToastAction.displayName = ToastPrimitives.Action.displayName

const ToastClose = React.forwardRef<
React.ElementRef<typeof ToastPrimitives.Close>,
Expand All @@ -76,15 +76,15 @@ const ToastClose = React.forwardRef<
ref={ref}
className={cn(
"absolute right-2 top-2 rounded-md p-1 text-foreground/50 opacity-0 transition-opacity hover:text-foreground focus:opacity-100 focus:outline-none focus:ring-2 group-hover:opacity-100 group-[.destructive]:text-red-300 group-[.destructive]:hover:text-red-50 group-[.destructive]:focus:ring-red-400 group-[.destructive]:focus:ring-offset-red-600",
className,
className
)}
toast-close=""
{...props}
>
<X className="h-4 w-4" />
</ToastPrimitives.Close>
));
ToastClose.displayName = ToastPrimitives.Close.displayName;
))
ToastClose.displayName = ToastPrimitives.Close.displayName

const ToastTitle = React.forwardRef<
React.ElementRef<typeof ToastPrimitives.Title>,
Expand All @@ -95,8 +95,8 @@ const ToastTitle = React.forwardRef<
className={cn("text-sm font-semibold", className)}
{...props}
/>
));
ToastTitle.displayName = ToastPrimitives.Title.displayName;
))
ToastTitle.displayName = ToastPrimitives.Title.displayName

const ToastDescription = React.forwardRef<
React.ElementRef<typeof ToastPrimitives.Description>,
Expand All @@ -107,12 +107,12 @@ const ToastDescription = React.forwardRef<
className={cn("text-sm opacity-90", className)}
{...props}
/>
));
ToastDescription.displayName = ToastPrimitives.Description.displayName;
))
ToastDescription.displayName = ToastPrimitives.Description.displayName

type ToastProps = React.ComponentPropsWithoutRef<typeof Toast>;
type ToastProps = React.ComponentPropsWithoutRef<typeof Toast>

type ToastActionElement = React.ReactElement<typeof ToastAction>;
type ToastActionElement = React.ReactElement<typeof ToastAction>

export {
type ToastProps,
Expand All @@ -124,4 +124,4 @@ export {
ToastDescription,
ToastClose,
ToastAction,
};
}
Loading

0 comments on commit 3dc8320

Please sign in to comment.