Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency and conflict #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix missing dependency and conflict #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3b7ffe
Added .gitignore
Nov 28, 2018
fef22cd
Fix missing wp-editor editor javascript dependency
Nov 28, 2018
9f0774c
Fixed conflict with "gutenberg-course" plugin
Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
composer.lock
/node_modules/
/vendor/
/logs/
/reports/

# You want to have .DS_Store and other environment files/packages in your .gitignore_global configuration.
# @see https://knowthecode.io/labs/local-development-environment-setup-mac/install-configure-git
# I'll include it here to help out.
.DS_Store
.DS_Store?
10 changes: 5 additions & 5 deletions jsforwp-how-to-gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ function jsforwphowto_editor_scripts()

// Enqueue the bundled block JS file
wp_enqueue_script(
'jsforwp-blocks-js',
'jsforwphowto-blocks-js',
plugins_url( $blockPath, __FILE__ ),
[ 'wp-i18n', 'wp-element', 'wp-blocks', 'wp-components', 'wp-api' ],
[ 'wp-i18n', 'wp-element', 'wp-blocks', 'wp-components', 'wp-api', 'wp-editor' ],
filemtime( plugin_dir_path(__FILE__) . $blockPath )
);

// Enqueue optional editor only styles
wp_enqueue_style(
'jsforwp-blocks-editor-css',
'jsforwphowto-blocks-editor-css',
plugins_url( $editorStylePath, __FILE__),
[ 'wp-blocks' ],
filemtime( plugin_dir_path( __FILE__ ) . $editorStylePath )
Expand All @@ -89,15 +89,15 @@ function jsforwphowto_scripts()

// Enqueue the bundled block JS file
wp_enqueue_script(
'jsforwp-blocks-frontend-js',
'jsforwphowto-blocks-frontend-js',
plugins_url( $blockPath, __FILE__ ),
[ 'wp-i18n', 'wp-element', 'wp-blocks', 'wp-components', 'wp-api' ],
filemtime( plugin_dir_path(__FILE__) . $blockPath )
);

// Enqueue frontend and editor block styles
wp_enqueue_style(
'jsforwp-blocks-css',
'jsforwphowto-blocks-css',
plugins_url($stylePath, __FILE__),
[ 'wp-blocks' ],
filemtime(plugin_dir_path(__FILE__) . $stylePath )
Expand Down