Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Handle PHP 7 Throwables in ApiProblemListener #52

Merged
merged 3 commits into from
Jul 24, 2017
Merged

Handle PHP 7 Throwables in ApiProblemListener #52

merged 3 commits into from
Jul 24, 2017

Conversation

MichaelGooden
Copy link
Contributor

@MichaelGooden MichaelGooden commented Nov 10, 2016 •
edited
Loading

ApiProblemListener was never updated to handle PHP 7 \Throwable, this PR adds required fix and related test.

(Composer update is due to some GitHub zipball shasums being out of date. Did not feel that was worth its own PR.)

@svycka
Copy link
Contributor

svycka commented Dec 14, 2016

Would be awesome to have it merged and released.

@MichaelGooden is there a reason why composer.lock is updated I don't see any changes in composer.json?

@svycka
Copy link
Contributor

svycka commented Dec 14, 2016

whoops sorry @MichaelGooden didn't read your comment :D

@MichaelGooden
Copy link
Contributor Author

Any change you could merge this @weierophinney ?

@MichaelGooden
Copy link
Contributor Author

MichaelGooden commented Jan 13, 2017 •
edited
Loading

@weierophinney Can you please merge this. This breaks this module on PHP 7.x.

@MichaelGooden
Copy link
Contributor Author

@ezimuel Can you please review this PR. It is a two line change with tests that is urgently needed to unbreak this library on PHP 7.x. Considering that PHP 5.6 has now passed its last planned release, this PR is essential.

@bartbrinkman
Copy link
Contributor

agreed, need this as well.

@bartbrinkman bartbrinkman mentioned this pull request Feb 9, 2017
Merged
@svycka
Copy link
Contributor

svycka commented Feb 10, 2017

@weierophinney is there anything we can do to help this merged?

@MichaelGooden
Copy link
Contributor Author

@weierophinney Any update on this? Is there anything more I can do to help the process move forward?

@MichaelGooden
Copy link
Contributor Author

Bump.

@weierophinney weierophinney merged commit fe79ffe into zfcampus:master Jul 24, 2017
weierophinney added a commit that referenced this pull request Jul 24, 2017
@weierophinney
Merge pull request #52 from MichaelGooden/hotfix/php7-throwables
ac0c2ac 
Handle PHP 7 Throwables in ApiProblemListener

Conflicts:
	composer.lock
weierophinney added a commit that referenced this pull request Jul 24, 2017
@weierophinney
Adds CHANGELOG for #52
928a96e
weierophinney added a commit that referenced this pull request Jul 24, 2017
@weierophinney
Merge branch 'hotfix/52'
0fb7cd2 
Close #52
weierophinney added a commit that referenced this pull request Jul 24, 2017
@weierophinney
Merge branch 'hotfix/52' into develop
b0bf194 
Forward port #52
@weierophinney
Copy link
Member

Thanks, @MichaelGooden

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Viperal Viperal Viperal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichaelGooden @svycka @bartbrinkman @weierophinney @Viperal