Fix Zend_Form_ElementTest #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour hasn't really changed because the intent of the test is to use an array of arrays in setOptions. What has changed is that PHP 8.0 supports calling functions with named parameters and will throw a Fatal if you try to access a parameter by name that does not exist. Digits::__construct has no param named bar ergo we get a Fatal. Signed-off-by: Alexander Wozniak <wozniak@oktopos.com> Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
glensc
force-pushed
the
Digits__construct
branch
from
985e0b9 to
832337f
Compare
falkenhawk
approved these changes
Mar 15, 2021
#77 was left as a catch-all for the remaining of @Megatherium changes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Megatherium on 3 Dec 2020:
See discussion here:
Extracted out of #77 which was @Megatherium changes from #32