Make Zend_Validate_Date work as expected under PHP 8.0 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By additionally catching an error where only an exception used to be caught and thus returning false on Zend_Validate_Date::isValid the validator now behaves the same under PHP8+ This also means that we don't need to catch the error in the test method anymore.
falkenhawk
approved these changes
Mar 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By additionally catching an error where only an exception used to be
caught and thus returning false on Zend_Validate_Date::isValid the
validator now behaves the same under PHP8+
This also means that we don't need to catch the error in the test method
anymore.
Extracted changes made by @Megatherium from #32