Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer php-parallel-lint/php-parallel-lint for php 8.0 #58

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Feb 8, 2021

The problem is that 5.3 can only use 1.0.0 as newer versions require newer runtime.

And 8.0.0 can't use 1.0.0 due to curly braces deprecation:

PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported

Example:

Parts of the commit originally by @Megatherium

The problem is that 5.3 can only use 1.0.0 as newer versions require
newer runtime.

And 8.0.0 can't use 1.0.0 due curly braces depecation:

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported

Commit originally by Alexander Wozniak
Signed-off-by: Alexander Wozniak <wozniak@oktopos.com>
@glensc glensc mentioned this pull request Feb 8, 2021
@glensc glensc marked this pull request as ready for review February 8, 2021 15:31
@falkenhawk falkenhawk merged commit 8f5689e into zf1s:master Feb 8, 2021
@glensc glensc deleted the allow-lint-for-php8 branch February 9, 2021 08:10
@glensc
Copy link
Contributor Author

glensc commented Feb 9, 2021

Rebased and dependant PR's ready for review/merge.

@glensc glensc mentioned this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants