[zend-openid] fix for Zend_OpenId_Consumer_Storage_File when symlinks are not used (i.e. on windows)
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for `Zend_OpenId_Consumer_Storage_File` when symlinks are not used (i.e. on windows) One of the files created in `Zend_OpenId_Consumer_Storage_File::addAssociations()` was being deleted for some unknown reason, but `Zend_OpenId_Consumer` relies on it to be there. Fixes errors in OpenId tests when running on windows. i.a. ``` Zend_Auth_Adapter_OpenIdTest::testAuthenticateLoginValid Failed asserting that false is true. ```
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for
Zend_OpenId_Consumer_Storage_Filewhen symlinks are not used (i.e. on windows) One of the files created inZend_OpenId_Consumer_Storage_File::addAssociations()was being deleted for some unknown reason, butZend_OpenId_Consumerrelies on it to be there.Fixes errors in OpenId tests when running on windows. i.a.