publish the whole zf1s/zf1 package #133

falkenhawk · 2022-10-05T08:26:49Z

resolves #57

despite what I wrote in #57 (comment), I've realized that it may make sense to publish the whole zf1s/zf1 package after all, to easy up the transition period, in which devs should eventually identify and pick only those components they really use, to install (which may not ever happen, but it's ok) ;)

Initially (after reading through valid arguments posted by @fredericgboutin-yapla in #128 (comment) ) I thought it would be enough if only replace definition "zendframework/zendframework1": ">=1.12.20" was added, while the whole framework could still be installed with git installation method, as described in #57 (comment),

and that

we do not want to bring in another official "full" package to packagist, introducing more confusion - which one to install, how would that relate to individual packages etc.

but...
screw that, we do not have to be that opinionated.

I am going to install the whole package zf1s/zf1 together with 1.15.0 release.

partikus · 2022-10-05T09:06:24Z

README.md

@@ -102,6 +103,19 @@ Currently everything should be compatible with **PHP 5.3-8.0**. _5.2 support is
 They may also contain some fixes, either for long-standing bugs, which haven't made their way into zf1 official repo before EOL, or newly found ones
 and (backwards compatible) adjustments (optimisations for composer autoloader mostly). Maybe even one or two new features.

+Still, the main purpose is to allow working on legacy projects on more modern systems, while opening the possibility to **migrate away from zf1 gradually, one component at a time**.


@falkenhawk what do you think about adding suggest section including all zf1s/* packages?

that might be an overkill 😅

you're right, let's ignore it

partikus · 2022-10-05T09:10:39Z

composer.json

@@ -117,6 +117,7 @@
        }
    },
    "replace": {
+        "zendframework/zendframework1": ">=1.12.20",


why >=1.12.20? Maybe we should replace only versions greater than >1.12.20
https://github.com/zendframework/zf1/tags

it's fine to cover last officially released version. zf1-future and diablomedia/zf1 have both configured it that way too.

partikus

Let's do that! I would verify the usage statistics within next few months.

glensc · 2022-10-05T18:10:43Z

composer.json

@@ -1,6 +1,6 @@
 {
    "name": "zf1s/zf1",
-    "description": "Monorepo for zf1s (Zend Framework 1) packages",
+    "description": "Zend Framework 1 complete package, PHP 5.3-8.0 compatible. Please consider using individual zf1s/zend-* packages instead - see README.",


not sure you should put usage to description of composer package. having block in readme is sufficient i believe.

I added it there deliberately, so that it is visible already in the packagist search

and also at the top of the package's page, with big font.

glensc · 2022-10-05T18:14:48Z

it's still not a drop-in to replacement to zendframework/zendframework1 i think, as paths are different, and require_once calls are gone, and loader is different (but actually works?).

does this solution actually satisfy what @fredericgboutin-yapla was talking about?

glensc · 2022-10-05T20:53:22Z

maybe for zf1-extras to work need to ~~restore~~ add "include-path" directives in the zf1s/zf1 package:

https://getcomposer.org/doc/04-schema.md#include-path

i.e add every package there:

packages/zend-*/library/Zend

falkenhawk · 2022-10-06T08:49:45Z

it's still not a drop-in to replacement to zendframework/zendframework1 i think, as paths are different, and require_once calls are gone, and loader is different (but actually works?).

It should be, as long as it is installed with composer. (manual installation method is not supported because of the packages folder structure, one would have to invent their autoloader rules, for ancient projects where composer is not available, but they may have better luck with e.g. zf1-future or https://github.com/magento/zf1/ which keep the original folder structure)

It should be also possible now to quickly switch between zf1-future/diablomedia/zf1/... and this zf1s/zf1 as replace rules are the same.

falkenhawk · 2022-10-06T08:54:06Z

As for zf1-extras, we cannot support that out of the box. That would have to be forked and adjusted, or include-path rules added locally in a project using it.

@fredericgboutin-yapla if you manage to couple zf1-extras or other packages with zf1s, please let us know here or in #128 🙏

glensc · 2022-10-07T07:46:13Z

@falkenhawk I think we can support here zf1-extras without modification, if we add include-path for all projects. the include path directives you add only to this root project, so the split-out packages will not be affected.

falkenhawk · 2022-10-07T09:28:22Z

I wouldn't want to list all packages/**/library folders in include-path, as such list would be very long and could potentially affect general php performance... 😬

publish the whole zf1s/zf1 package

37ce276

falkenhawk requested review from marcing and partikus October 5, 2022 08:26

partikus requested changes Oct 5, 2022

View reviewed changes

add info about zf1s/zf1 package to changelog

cd34913

falkenhawk force-pushed the publish-whole-package branch from 702981c to 670a47b Compare October 5, 2022 10:20

falkenhawk requested a review from partikus October 5, 2022 13:11

adjust description which will appear on packagist for zf1s/zf1 package

1a93b55

falkenhawk force-pushed the publish-whole-package branch from 670a47b to 1a93b55 Compare October 5, 2022 13:15

partikus approved these changes Oct 5, 2022

View reviewed changes

partikus merged commit be1785d into master Oct 5, 2022

partikus deleted the publish-whole-package branch October 5, 2022 14:47

glensc reviewed Oct 5, 2022

View reviewed changes

falkenhawk mentioned this pull request Nov 8, 2022

zf1s/zf1: require php extensions in dev only #136

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

publish the whole zf1s/zf1 package #133

publish the whole zf1s/zf1 package #133

falkenhawk commented Oct 5, 2022 •

edited

Loading

partikus Oct 5, 2022

falkenhawk Oct 5, 2022

partikus Oct 5, 2022

partikus Oct 5, 2022

falkenhawk Oct 5, 2022

partikus left a comment

glensc Oct 5, 2022

falkenhawk Oct 6, 2022 •

edited

Loading

glensc commented Oct 5, 2022

glensc commented Oct 5, 2022 •

edited

Loading

falkenhawk commented Oct 6, 2022

falkenhawk commented Oct 6, 2022

glensc commented Oct 7, 2022

falkenhawk commented Oct 7, 2022

publish the whole zf1s/zf1 package #133

publish the whole zf1s/zf1 package #133

Conversation

falkenhawk commented Oct 5, 2022 • edited Loading

partikus Oct 5, 2022

Choose a reason for hiding this comment

falkenhawk Oct 5, 2022

Choose a reason for hiding this comment

partikus Oct 5, 2022

Choose a reason for hiding this comment

partikus Oct 5, 2022

Choose a reason for hiding this comment

falkenhawk Oct 5, 2022

Choose a reason for hiding this comment

partikus left a comment

Choose a reason for hiding this comment

glensc Oct 5, 2022

Choose a reason for hiding this comment

falkenhawk Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

glensc commented Oct 5, 2022

glensc commented Oct 5, 2022 • edited Loading

falkenhawk commented Oct 6, 2022

falkenhawk commented Oct 6, 2022

glensc commented Oct 7, 2022

falkenhawk commented Oct 7, 2022

falkenhawk commented Oct 5, 2022 •

edited

Loading

falkenhawk Oct 6, 2022 •

edited

Loading

glensc commented Oct 5, 2022 •

edited

Loading