Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Zend_Db_Table_Select->setIntegrityCheck() flag-parameter phpdoc #119

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 14, 2022

No description provided.

Copy link
Contributor

@jack-worman jack-worman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well fix the @var annotation on $this->_integrityCheck while you are here

@glensc

This comment has been minimized.

@glensc

This comment has been minimized.

@staabm staabm changed the title fix phpdoc fix Zend_Db_Table_Select->setIntegrityCheck() flag-parameter phpdoc Jan 14, 2022
@staabm staabm changed the title fix Zend_Db_Table_Select->setIntegrityCheck() flag-parameter phpdoc fix Zend_Db_Table_Select->setIntegrityCheck() flag-parameter phpdoc Jan 14, 2022
@staabm
Copy link
Contributor Author

staabm commented Jan 14, 2022

fixed per review. thx for the feedback

@jack-worman
Copy link
Contributor

@glensc I don't entirely agree, but I will keep that in mind in the future.

@glensc

This comment has been minimized.

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@falkenhawk falkenhawk merged commit 8726d1a into zf1s:master Oct 4, 2022
@staabm staabm deleted the patch-1 branch October 4, 2022 12:11
@falkenhawk falkenhawk mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants