Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assemble signature #1

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Update assemble signature #1

merged 1 commit into from
Dec 27, 2018

Conversation

hairmare
Copy link

This is a step in the direction of making this work with php 7.2. It gets rid of the Declaration of Zend_Rest_Route::assemble($data = Array, $reset = false, $encode = true) must be compatible with Zend_Controller_Router_Route_Module::assemble($data = Array, $reset = false, $encode = true, $partial = false) exception thrown when loading the module. It is backwards compatible with previously supported versions of php.

I'll probably have some more changes pertaining to php 7.2 since it is finally becoming the standard on most distros. Some of them will be to other repos in the zf1s orga. Are you maintaining these forks?

Make the Zend_Rest_Route::assemble signature match Zend_Controller_Router_Route_Module::assemble as need by php 7.2.
@falkenhawk
Copy link
Member

Thank you @hairmare ! I'll be happy to merge all the other compat PRs whenever you prepare them.

@hairmare hairmare deleted the patch-1 branch December 27, 2018 10:02
@hairmare
Copy link
Author

Awesome, Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants