Drop support for ZendX pseudo namespace #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for the ZendX pseudo namespase which was only used for some experimental features that later made it into the main zf1 code base.
As far as I can tell this hasn't been used anywhere for quite a while now.
Please let me know if you'd like me to search for a solution that doesn't drop support for the ZendX pseudo namespace. Dropping support for it seemed like the easiest fix for some of the issues I found during testing but it might be possible to workaround this by overriding the namespacing in my code somewhere. Due to the fact that the loader usually gets instanciated by Zend_Application overriding the namespaces isn't as straight forward as I'd like it to be.