Add zf1s/zend-filter as required dependency to composer.json #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViewRenderer in zf1s/zend-controller directly depends on Zend_Filter Classes
falkenhawk
added a commit
that referenced
this pull request
Dec 12, 2022
- substr(): Passing null to parameter #1 ($string) of type string is deprecated - strtolower(): Passing null to parameter #1 ($string) of type string is deprecated - strlen(): Passing null to parameter #1 ($string) of type string is deprecated - trim(): Passing null to parameter #1 ($string) of type string is deprecated - str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated - strstr(): Passing null to parameter #1 ($haystack) of type string is deprecated - http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated - current(): Calling current() on an object is deprecated - preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated - preg_match(): Passing null to parameter #4 ($flags) of type int is deprecated - always construct Zend_Exception with string message, avoid null - Implicit conversion from float-string "x.xyz" to int loses precision - PDOStatement::fetch(): Passing null to parameter #2 ($cursorOrientation) of type int is deprecated - ctype_space(): Argument of type null will be interpreted as string in the future - file_get_contents(): Passing null to parameter #2 ($use_include_path) of type bool is deprecated - imagefilledpolygon(): Using the $num_points parameter is deprecated - Implicit conversion from float to int loses precision - PDOStatement::bindParam(): Passing null to parameter #4 ($maxLength) of type int is deprecated - preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated - ctype_print(): Argument of type int will be interpreted as string in the future - trim(): Passing null to parameter #1 ($string) of type string is deprecated etc.
|
@dmnc @falkenhawk can this be merged? Given that the version number is updated to the current version by @Anyqax? |
|
@smhg yes. It just better reflects the realities of the code. |
|
I wasn't aware of this PR. If you have time, please submit a pull request to https://github.com/zf1s/zf1/pulls monorepo - this repo is readonly, updated automatically when new zf1s version is released |
|
Thank you for the quick response! I've created the PR. |
|
closed in favor of zf1s/zf1#171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewRenderer in zf1s/zend-controller directly depends on Zend_Filter Classes