Map marker overlap #2530
Open
Map marker overlap #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbusstop
reviewed
Feb 2, 2025
| @@ -308,24 +308,9 @@ const OrganizerMapRenderer: FC<OrganizerMapRendererProps> = ({ | |||
| return -1; | |||
| } else { | |||
| // When none of the two areas are selected, sort them | |||
| // by size, so that big ones are underneith and the | |||
| // by size, so that big ones are underneath and the | |||
djbusstop
reviewed
Feb 2, 2025
k-nut
force-pushed
the
issue-2445/map-marker-indexes
branch
from
df8c3f2 to
20fa07a
Compare
river-bbc
approved these changes
Feb 2, 2025
djbusstop
reviewed
Feb 2, 2025
Comment on lines
+6
to
+12
| export const DivIconMarker: FC< | ||
| { | ||
| iconAnchor?: [number, number]; | ||
| } & Pick< | ||
| MarkerProps, | ||
| 'children' | 'draggable' | 'eventHandlers' | 'position' | 'zIndexOffset' | ||
| > |
djbusstop
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the markers in the center of the area in a map are positioned on top of the individual markers.
Screenshots
Changes
There are two commits:
zIndexOffsetproperty to theDivIconMarkerand uses it on the markers for the center of the areas.The leaflet library automatically sets z indexes on all markers so that they display properly. It allows providing the zIndexOffset to explicitly place some markers on a higher level which is just what we want here.
Related issues
Resolves #2445