Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset date UI between mappings #2470

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

helihard
Copy link
Collaborator

Description

This PR resets the date UI between mappings when more than one column is being mapped to a date field.

Screenshots

reset-date-ui

Changes

  • Adds useEffect hook to reset the date UI when the columnIndex changes.

Related issues

Resolves #2438

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the code and tried the preview build, and this fixes the bug. Nice work @helihard!

@richardolsson richardolsson merged commit d98aae2 into main Jan 18, 2025
6 checks passed
@richardolsson richardolsson deleted the issue-2438/reset-date-ui branch January 18, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date UI is not reset when switching between two date columns
2 participants