-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
250107 Release #2459
Merged
Merged
250107 Release #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes little semantic sense to include it as a child of the form.
Was trying some stuff earlier and forgot to remove this dead-end before committing.
…rror Display error message when button in email still has its default text
…storybook Automatically build TypeDoc and Storybook in CI
Since the pages router counterpart is called ScaffoldedEnvVars it's inconsistent if this one's called ClientContextEnvVariables. They should either both be …EnvVars or both be …EnvVariables.
Add survey footer
Add documentation about environment variables
Signed-off-by: Alexander Schreiner <github@alexander-schreiner.de> Signed-off-by: Alexander Schreiner (ext.) <github@alexander-schreiner.de>
Custom email sender
to prevent local dev server from crashing Signed-off-by: Alexander Schreiner <github@alexander-schreiner.de>
…-typo Fixed broken local devserver due to env vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR packages the 250107 release, which contains a number of mail fixes made over the holidays, as well as a new feature to send email from different sender configurations.
Contributors
New features
Customized email senders
This release adds a new capability to the email feature, allowing the author of an email to choose what sender configuration to use. This makes it possible to use Zetkin to send multiple categories of emails with different senders, e.g. one newsletter from the organization, another newsletter with the sender being the organization leader, and other email from an organizer to mobilize for some event.
This release does not yet add a UI for creating these configurations (they have to be created via the API) but it implements a UI in the composer to pick a configuration (and in doing so removes the "Settings" tab that used to be in the sidebar).
Bug fixes & minor improvements